Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[match] Check validity of provisioning profile certificates when force_for_new_certificates option is provided #20194

Merged
merged 1 commit into from Apr 21, 2022

Conversation

nekrich
Copy link
Contributor

@nekrich nekrich commented Apr 19, 2022

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

When a certificate expires (not revoked) provisioning profile stays valid.
And if we regenerate certificate count will not differ:

  • For portal certificates, we filter out the expired one but includes a new certificate;
  • Profile still contains an expired certificate and is valid.
    Thus, we need to check the validity of profile certificates too.

It's my bad that I wasn't counting that the provisioning profile stays valid when certificates expire.

Description

Simplty add .select(&:valid?) 馃槄

Testing Steps

  • Get the certificate contained in the provisioning profile expired 馃し
  • match(force_for_new_certificates: true)

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhhhhh, this is a great catch! Thanks for fixing this 馃檶

@joshdholtz joshdholtz merged commit ab18b91 into fastlane:master Apr 21, 2022
@fastlane-bot
Copy link

Congratulations! 馃帀 This was released as part of fastlane 2.205.2 馃殌

@fastlane fastlane locked and limited conversation to collaborators Jun 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants