Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[match] add option to skip google account confirmation #20223

Merged
merged 1 commit into from May 18, 2022

Conversation

trsneed
Copy link
Contributor

@trsneed trsneed commented Apr 28, 2022

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Why?

We are using google secrets manager for our certificates, and are adding a CD layer to prevent delivering to the AppStore from developer machines. When running fastlane in non-interactive mode on our CI/CD servers we cannot answer the question to use the system's google account, configured with gcloud. By using a service worker with the gcloud auth GitHub action we can auth the service user on a server and bypass the need for a gc_keys.json file.

Resolves #14500

Description

Adds a match parameter to skip the optional confirmation step.

Testing

  • Set my environment to CI and saw the issue with the workflow.
  • Added an optional skip_google_cloud_account_confirmation match parameter that defaults to false.
  • Set the parameter to true, saw no confirmation prompt.
  • Set the parameter to false, saw the confirmation prompt.

@trsneed trsneed changed the title Add option to skip google account confirmation [match] Add option to skip google account confirmation May 16, 2022
@joshdholtz joshdholtz changed the title [match] Add option to skip google account confirmation [match] add option to skip google account confirmation May 18, 2022
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a cool use case! I would have never thought about this 😅 But thanks for the contribution! Really appreciate it 🥰

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.206.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants