[spaceship] update Spaceship::ConnectAPI::User model to include delete! method

[liamnichols]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

I've been using fastlane and Spaceship to script some batch operations for managing our App Store Connect user access since the web-ui kind of sucks for anything other than one-off changes 😄

While doing so, I needed to delete some old accounts but noticed that while Spaceship::ConnectAPI::Users::API defines a delete_user method, it's not exposed on Spaceship::ConnectAPI::User model like it is for UserInvitation.

fastlane/spaceship/lib/spaceship/connect_api/users/users.rb

Lines 26 to 29 in eb4584e

	# Delete existing user
	def delete_user(user_id: nil)
	users_request_client.delete("users/#{user_id}")
	end

Description

In this change, I define a new delete! method in an almost identical way to UserInvitation.delete!

Testing Steps

N/A

[lucgrabowski]

Thanks for adding this :) LGTM 🔥

[joshdholtz]

This looks great! Thank you so much for adding this 😊

[fastlane-bot]

Congratulations! 🎉 This was released as part of fastlane 2.206.0 🚀