Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spaceship] update buildDeliveries request to use app id in path #20268

Merged
merged 2 commits into from May 18, 2022

Conversation

lucgrabowski
Copy link
Contributor

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Resolves #20239

Description

fastlane pilot builds fails because buildDeliveries request fails with:

[!] The request could not be completed because: (Spaceship::AccessForbiddenError) The given operation is not allowed - The resource 'buildDeliveries' does not allow 'GET_COLLECTION'. Allowed operations are: GET_INSTANCE

It seems that url path for request on AppStore Connect was changed from /buildDeliveries (with app id passed in a filter) to /apps/<app_id>/buildDeliveries.

Tested by calling bundle exec fastlane pilot builds just after build is uploaded to AppStore Connect when it's still not visible in Testflight and after a while when it is visible in Testflight in Processing state

Testing Steps

Update Gemfile and run bundle install

gem "fastlane", :git => "https://github.com/fastlane/fastlane.git", :branch => "lucgrabowski-build-deliveries-request-update"

@lucgrabowski lucgrabowski changed the title [spaceship] Update buildDeliveries request to use app_id in path instead [spaceship] Update buildDeliveries request to use app id in path May 11, 2022
Copy link

@lehlen lehlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@joshdholtz joshdholtz changed the title [spaceship] Update buildDeliveries request to use app id in path [spaceship] update buildDeliveries request to use app id in path May 18, 2022
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thank you so much for fixing 🥰

@joshdholtz joshdholtz merged commit 3ba6927 into master May 18, 2022
@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.206.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Jul 18, 2022
@lacostej lacostej deleted the lucgrabowski-build-deliveries-request-update branch November 24, 2023 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fastlane pilot builds always fail
4 participants