New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sigh][match][spaceship] add missing inhouse to mac profile types #20353
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
:Edited |
Oh, my bad! Was this still a work in progress PR?! 😱 |
No, no. Feel free to edit it. I stuck on it and wasn't able to fix it by myself. |
In Monday I will be able to test it out if your changes fix my issue :) |
Yay! Something got changed :D |
Ok, we fixed this issue and this is working now 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding that these were missing! ❤️
Hey @DuMaM 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
Sorry to say but we need to revert this PR :(
After we merge it, I found bug in my fastlane code which led to those problems. Sorry for trouble 🙏 cc: @joshdholtz |
@DuMaM Hey! It still seems like this might be okay to have in here 🙃 Unless something is specifically broken with this 🤷♂️ This adds more functionality with Apple ID auth. Does this PR break anything or just not needed by what you were doing? |
No, it works fine. It basically adding something what is not supported in Apple Connect API. At the end it may confuse people. |
Congratulations! 🎉 This was released as part of fastlane 2.207.0 🚀 |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validMotivation and Context
This resolves #20352
Description
I added missing inhouse definitions for MacOS platfrom.
Testing Steps