Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sigh][match][spaceship] add missing inhouse to mac profile types #20353

Merged
merged 3 commits into from Jun 29, 2022
Merged

[sigh][match][spaceship] add missing inhouse to mac profile types #20353

merged 3 commits into from Jun 29, 2022

Conversation

DuMaM
Copy link
Contributor

@DuMaM DuMaM commented Jun 3, 2022

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This resolves #20352

Description

I added missing inhouse definitions for MacOS platfrom.

Testing Steps

@google-cla
Copy link

google-cla bot commented Jun 3, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@DuMaM DuMaM closed this Jun 3, 2022
@DuMaM DuMaM deleted the fix-mac-enterprise branch June 3, 2022 15:29
@DuMaM DuMaM restored the fix-mac-enterprise branch June 7, 2022 14:54
@DuMaM DuMaM reopened this Jun 7, 2022
@joshdholtz joshdholtz changed the title Add missing inhouse to mac profile types [sigh][match][spaceship] add missing inhouse to mac profile types Jun 25, 2022
@DuMaM
Copy link
Contributor Author

DuMaM commented Jun 25, 2022

:Edited
@joshdholtz Thanks, for help because it was really needed.
I wasn't able to fully track error why this is not working, so thx for changes.

@joshdholtz
Copy link
Member

Oh, my bad! Was this still a work in progress PR?! 😱

@DuMaM
Copy link
Contributor Author

DuMaM commented Jun 25, 2022

No, no. Feel free to edit it. I stuck on it and wasn't able to fix it by myself.

@DuMaM
Copy link
Contributor Author

DuMaM commented Jun 25, 2022

In Monday I will be able to test it out if your changes fix my issue :)

@DuMaM
Copy link
Contributor Author

DuMaM commented Jun 27, 2022

[!] The request could not be completed because:
        Unable to process request - PLA Update available - You currently don't have access to this membership resource. To resolve this issue, your team's Account Holder,<holder name>, must agree to the latest Program License Agreement.

Yay! Something got changed :D
I reached my account holder for help here and we will see if this works.

@DuMaM
Copy link
Contributor Author

DuMaM commented Jun 27, 2022

Ok, we fixed this issue and this is working now 🎉

Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding that these were missing! ❤️

@joshdholtz joshdholtz merged commit 6f81747 into fastlane:master Jun 29, 2022
@DuMaM DuMaM deleted the fix-mac-enterprise branch June 29, 2022 11:16
@fastlane-bot
Copy link

Hey @DuMaM 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@DuMaM
Copy link
Contributor Author

DuMaM commented Jun 30, 2022

Sorry to say but we need to revert this PR :(
https://developer.apple.com/documentation/appstoreconnectapi/list_and_download_profiles

IOS_APP_DEVELOPMENT, IOS_APP_STORE, IOS_APP_ADHOC, IOS_APP_INHOUSE, MAC_APP_DEVELOPMENT, MAC_APP_STORE, MAC_APP_DIRECT, TVOS_APP_DEVELOPMENT, TVOS_APP_STORE, TVOS_APP_ADHOC, TVOS_APP_INHOUSE, MAC_CATALYST_APP_DEVELOPMENT, MAC_CATALYST_APP_STORE, MAC_CATALYST_APP_DIRECT

After we merge it, I found bug in my fastlane code which led to those problems.
I fixed it, and developer_id (== mac enterprise 🙄 )started to working as it supposed to.
I must admit I got confused by apple documentation.

Sorry for trouble 🙏

cc: @joshdholtz

@joshdholtz
Copy link
Member

@DuMaM Hey! It still seems like this might be okay to have in here 🙃 Unless something is specifically broken with this 🤷‍♂️ This adds more functionality with Apple ID auth.

Does this PR break anything or just not needed by what you were doing?

@DuMaM
Copy link
Contributor Author

DuMaM commented Jun 30, 2022

No, it works fine. It basically adding something what is not supported in Apple Connect API. At the end it may confuse people.
The only point in leaving this code here, is to add some warning msg that there is no such thing like InHouse (match enterprise type) for enterprise Mac certs. They should use developer id instead.

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.207.0 🚀

@fastlane fastlane locked and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression] Match Catalyst and Mac for enterprise is unable to find cert
3 participants