[Ruby] Ruby 2.6 is now the minimum (dropping Ruby 2.5) #20413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdholtz
commented
Jun 25, 2022
Comment on lines
+27
to
+32
| Lint/ErbNewArguments: | ||
| Enabled: false | ||
|
|
||
| Style/SlicingWithRange: | ||
| Enabled: false | ||
|
|
There was a problem hiding this comment.
Will disable these later but wanted to make this change PR minimal 🤷♂️
crazymanish
added a commit
that referenced
this pull request
Jun 26, 2022
* master: [pilot] added the Pilot::TesterExporter class unit tests (#20394) Add device Google Pixel 5 (#20389) [action][update_info_plist] improve the plist file-path option validation check (#20356) Specify s3 object prefix (#20344) [snapshot] Add missing iPod touch to Generated Snapshot Reports (#20337) [Ruby] Ruby 2.6 is now the minimum (dropping Ruby 2.5) (#20413)
|
Hey @joshdholtz 👋 Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉 Please let us know if this change requires an immediate release by adding a comment here 👍 |
fastlane-bot
added
status: released
and removed
status: included-in-next-release
labels
|
Congratulations! 🎉 This was released as part of fastlane 2.207.0 🚀 |
|
Shouldn't this kinda change warrant a major version bump, rather than a minor bump? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Ruby 2.5 has been end-of-lifed 1 year and 2 months ago on March 31st, 2021.
Some of our dependencies are bumping to a minimum of Ruby 2.6 which causes some rough installations. Specifically,
signet's latest release of0.17no longer supports Ruby 2.5 andsignetis used by a bunch of Google gems.Description
fastlane.gemspecto minimum Ruby 2.6.rubocop.ymlto target of Ruby 2.6