Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[match] suppress null byte message #20497

Merged
merged 1 commit into from Jul 22, 2022
Merged

[match] suppress null byte message #20497

merged 1 commit into from Jul 22, 2022

Conversation

getaaron
Copy link
Collaborator

@getaaron getaaron commented Jul 21, 2022

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

#20187 introduced the ability to pass either a file path or the raw cert data to self.get_cert_info. It works by calling File.exist? which prints a harmless error message when a cert is passed in:

ERROR [2022-07-20 09:52:59.80]: get_cert_info: path name contains null byte

This PR suppresses the message and resolves #20489.

Description

Catches the error when it's raised and does nothing.

I tested the changes by running match and observed that the error message no longer prints.

Testing Steps

Run match; notice the error message is gone.

@getaaron getaaron marked this pull request as ready for review July 22, 2022 13:33
Copy link
Member

@crazymanish crazymanish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯💯

@getaaron getaaron merged commit c6ef9b1 into master Jul 22, 2022
@getaaron getaaron deleted the match-null-byte branch July 22, 2022 15:11
@tejassharma96
Copy link
Contributor

sorry about that! thanks for finding and fixing the issue 😅

@fastlane-bot
Copy link

Hey @getaaron 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@fastlane-bot
Copy link

Congratulations! 🎉 This was released as part of fastlane 2.209.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_cert_info: path name contains null byte
4 participants