Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[screengrab] fix formatting of the screengrab / capture_android_screenshots docs #20597

Merged
merged 1 commit into from Nov 15, 2022

Conversation

AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Aug 24, 2022

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

The generated HTML for this page renders some of the code blocks incorrectly.

image

Description

Hopefully, by adding newlines before those code blocks it will fix the issue in the HTML generated by mkdocs.

Testing Steps

Warning: I did NOT run mkdocs on the resulting file to check that it actually solves the issue on the generated HTML (as I don't have mkdocs installed and I'm a bit short on time today to install it).

A reviewer could try to do that first though, to confirm the changes in this PR fix the formatting issue.

The generated HTML for this page renders some of the code blocks incorrectly. Hopefully, by adding newlines before those code blocks it will fix the issue in the HTML generated by mkdocs.
@AliSoftware AliSoftware changed the title Fix formatting code block fences Fix formatting of the screengrab docs Aug 24, 2022
@AliSoftware AliSoftware changed the title Fix formatting of the screengrab docs Fix formatting of the screengrab / capture_android_screenshots docs Aug 24, 2022
@joshdholtz joshdholtz changed the title Fix formatting of the screengrab / capture_android_screenshots docs [screengrab] fix formatting of the screengrab / capture_android_screenshots docs Nov 15, 2022
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to just merge this to see if this fixes this issue because I like how this looks in the markdown anyway 😊

@joshdholtz joshdholtz merged commit aea3af8 into fastlane:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants