Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deliver] fix bug when canceling a rejected submission #20754

Merged

Conversation

merchang
Copy link
Contributor

@merchang merchang commented Oct 18, 2022

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Resolves #20128

Description

When executing .get_in_progress_review_submission.cancel_submission and the app submission is successfully canceled, .app_store_state of the canceled app version remains as REJECTED

Current code expects it to change to DEVELOPER_REJECTED which never happens, causing the loop described in #20128

Since the app store state of an app is REJECTED both before and after its submission is successfully canceled, this change instead relies on .get_in_progress_review_submission returning nil to break the polling loop. .get_in_progress_review_submission returning not nil is what initiates the code block in the first place.

@google-cla
Copy link

google-cla bot commented Oct 18, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@joshdholtz joshdholtz changed the title fix bug when canceling a rejected submission [deliver] fix bug when canceling a rejected submission Nov 16, 2022
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this makes so much sense! I can't believe I forgot to change this 😱 Thanks for fixing!

@joshdholtz joshdholtz merged commit bae43ea into fastlane:master Nov 16, 2022
@fastlane-bot
Copy link

Hey @merchang 👋

Thank you for your contribution to fastlane and congrats on getting this pull request merged 🎉
The code change now lives in the master branch, however it wasn't released to RubyGems yet.
We usually ship about once a week, and your PR will be included in the next one.

Please let us know if this change requires an immediate release by adding a comment here 👍
We'll notify you once we shipped a new release with your changes 🚀

@bartpowers
Copy link

Hello, When is the next release planned?

@alexcroox
Copy link

alexcroox commented Jan 3, 2023

This would be great to get released. Currently can't submit if previous submission was rejected by Apple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build stucking on cancel submission step.
5 participants