Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action][spm] deprecate build_path option in favor of scratch_path, as recommended by Swift CLI #20814

Merged
merged 4 commits into from Dec 13, 2023

Conversation

Tavernari
Copy link
Contributor

@Tavernari Tavernari commented Nov 2, 2022

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

The swift cli has been warning about the build-path deprecation.

Description

This PR adds the option to use scratch_path instead of build_path, but it kept the build_path available since the swift cli is still accepting it as a warning.
I tested it, just changing the option.

Testing Steps

Using this PR as the Fastlane source.

  1. Create an SPM project
  2. Initialise fastlane
  3. Add to their Fastfile the spm action with scratch_path instead of build_path
  4. Change scratch_path to build_path and it should work as well.

@google-cla
Copy link

google-cla bot commented Nov 2, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Tavernari
Copy link
Contributor Author

Failed examples:

rspec ./fastlane/spec/actions_specs/update_fastlane_spec.rb:13 # Fastlane Fastlane::FastFile update_fastlane when no update needed
rspec ./fastlane/spec/actions_specs/update_fastlane_spec.rb:28 # Fastlane Fastlane::FastFile update_fastlane when update with RubyGems
rspec ./fastlane/spec/actions_specs/update_fastlane_spec.rb:68 # Fastlane Fastlane::FastFile update_fastlane when update with Homebrew

I am getting these errors when running bundle exec rspec.

@Tavernari Tavernari changed the title Deprecate spm's build_path option [spm] deprecate spm's build_path option Nov 2, 2022
Copy link
Member

@joshdholtz joshdholtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know about thisscratch-path change 😅 Gave one suggestion and then we can get this merged!

fastlane/lib/fastlane/actions/spm.rb Outdated Show resolved Hide resolved
@joshdholtz joshdholtz changed the title [spm] deprecate spm's build_path option [action][spm] deprecate spm's build_path option Nov 15, 2022
@Tavernari
Copy link
Contributor Author

Didn't know about thisscratch-path change 😅 Gave one suggestion and then we can get this merged!

What kind of suggestion?

Copy link
Collaborator

@lacostej lacostej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @joshdholtz's requested changes have been accepted. So we should be good to merge this.

Thanks for the contribution!

Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Neat!

Thank you for your contribution @Tavernari 🤗

@rogerluan rogerluan dismissed joshdholtz’s stale review December 13, 2023 15:05

Comments were addressed :)

@rogerluan rogerluan changed the title [action][spm] deprecate spm's build_path option [action][spm] deprecate build_path option in favor of scratch_path, as recommended by Swift CLI Dec 13, 2023
@rogerluan rogerluan merged commit 9e76f3e into fastlane:master Dec 13, 2023
2 checks passed
@Tavernari
Copy link
Contributor Author

Thanks!! 😊

SubhrajyotiSen pushed a commit to KeepTruckin/fastlane that referenced this pull request Jan 17, 2024
…`, as recommended by Swift CLI (fastlane#20814)

* Deprecate spm's build_path option

* Add deprecated message when use build_path on spm action

Co-authored-by: Josh Holtz <me@joshholtz.com>

* Remove unnecessary warning message

---------

Co-authored-by: Josh Holtz <me@joshholtz.com>
Co-authored-by: Jerome Lacoste <jerome.lacoste@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants