New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[action][spm] deprecate build_path
option in favor of scratch_path
, as recommended by Swift CLI
#20814
[action][spm] deprecate build_path
option in favor of scratch_path
, as recommended by Swift CLI
#20814
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I am getting these errors when running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know about thisscratch-path
change 😅 Gave one suggestion and then we can get this merged!
Co-authored-by: Josh Holtz <me@joshholtz.com>
What kind of suggestion? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @joshdholtz's requested changes have been accepted. So we should be good to merge this.
Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Neat!
Thank you for your contribution @Tavernari 🤗
build_path
option in favor of scratch_path
, as recommended by Swift CLI
Thanks!! 😊 |
…`, as recommended by Swift CLI (fastlane#20814) * Deprecate spm's build_path option * Add deprecated message when use build_path on spm action Co-authored-by: Josh Holtz <me@joshholtz.com> * Remove unnecessary warning message --------- Co-authored-by: Josh Holtz <me@joshholtz.com> Co-authored-by: Jerome Lacoste <jerome.lacoste@gmail.com>
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
The swift cli has been warning about the build-path deprecation.
Description
This PR adds the option to use scratch_path instead of build_path, but it kept the build_path available since the swift cli is still accepting it as a warning.
I tested it, just changing the option.
Testing Steps
Using this PR as the Fastlane source.