Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spaceship] Remove unused params in ConnectAPI::Device #20931

Merged
merged 1 commit into from Dec 14, 2022

Conversation

getaaron
Copy link
Collaborator

@getaaron getaaron commented Dec 13, 2022

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

  • find_by_udid takes a platform param which is never used
  • find_or_create takes an include_disabled param which is never used

Description

This PR deletes them since they don't do anything.

Fastlane doesn't call them but these may be (very minor) breaking changes for anyone calling these methods manually so we should be sure to mention it in the release notes.

Testing Steps

Just run rspec and the existing tests continue to pass since the parameters are never used by any code path.

@getaaron getaaron changed the title Remove unused params in ConnectAPI::Device [spaceship] Remove unused params in ConnectAPI::Device Dec 14, 2022
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@getaaron getaaron merged commit 22975a5 into master Dec 14, 2022
@getaaron getaaron deleted the remove-platform branch December 14, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants