Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with releases containing retained versions (#20997) #20998

Merged
merged 1 commit into from Oct 28, 2023

Conversation

mmiani
Copy link
Contributor

@mmiani mmiani commented Jan 17, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

This PR aims to resolve #20997

Description

When a release in the Google Play Store contains a retained version, update_rollout is failing to complete the rollout as it is sending the retained version to the Google Publisher API.
Updated the code to always pick the biggest version code as that will always correspond with the latest release

Testing Steps

1- Release a new version to the Google Play Store retaining the previous version

Screenshot 2023-01-17 at 6 06 02 pm

2- Complete the rollout for that version

supply(
          track: options[:track],
          rollout: options: 1.0,
          skip_upload_apk: true,
          skip_upload_metadata: true,
          skip_upload_images: true,
          skip_upload_screenshots: true,
          skip_upload_changelogs: true,
          skip_upload_aab: true,
          package_name: options[:package]
        )

Fix issue with releases containing retained versions failing to complete the staged rollout in the Google Play Store.
@google-cla
Copy link

google-cla bot commented Jan 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mmiani
Copy link
Contributor Author

mmiani commented Jan 17, 2023

@bmcadams, this PR should fix the issue (#16362) you reported a while back and was closed due to inactivity.
In the meantime, you can fork the repo, cherry-pick this fix and install the gem from your forked repository as a workaround.
gem "fastlane", :git => 'https://github.com/<username>/fastlane'

@lineardevon
Copy link

We've had to use a forked repo since January to work around this issue with @mmiani fix. Would be lovely to be back on main repo.

@getaaron could you give this a quick review?

@getaaron
Copy link
Collaborator

Thanks for the PR, @mmiani. Looks good 👍

@getaaron getaaron merged commit fbad7d8 into fastlane:master Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing to complete a staged rollout for a release containing a retained bundle
3 participants