Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action][upload_symbols_to_crashlytics] allow '~' in binary path #21032

Merged

Conversation

GevaZeichner
Copy link
Contributor

@GevaZeichner GevaZeichner commented Feb 8, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Resolves #21031

Description

Added File.expand_path for the parameter validation, similar to the fix done here for Pilot: #9481

Testing Steps

Run it again locally and on CI with binary_path: "~/cloned_source_packages_path/checkouts/firebase-ios-sdk/Crashlytics/upload-symbols".

Copy link
Collaborator

@lacostej lacostej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lacostej lacostej changed the title [UploadSymbolsToCrashlyticsAction] Allow '~' in binary path [action][upload_symbols_to_crashlytics] allow '~' in binary path Dec 12, 2023
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Neat!

I've checked that the actual implementation of upload_symbols_to_crashlytics already expands the path:

command << File.expand_path(params[:binary_path]).shellescape

So this was really just a limitation on the verification block :) well done, @GevaZeichner , thank you! 🚀

@rogerluan rogerluan merged commit a8a6e8e into fastlane:master Dec 13, 2023
SubhrajyotiSen pushed a commit to KeepTruckin/fastlane that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UploadSymbolsToCrashlyticsAction] cannot reference home directory in "binary_path" parameter
3 participants