Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[precheck] print the HTTP status as the failure reason when it's not 200 #21051

Merged
merged 1 commit into from Oct 16, 2023

Conversation

rogerluan
Copy link
Member

@rogerluan rogerluan commented Feb 15, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Any status code different than 200 would simply print the failing URL. But when that URL works fine for us, users, that's confusing. Showing explicitly what was the HTTP code received by fastlane's faraday script helps a lot identifying what the issue is.

Description

N/A

Testing Steps

To test this branch, modify your Gemfile as:

gem 'fastlane', git: 'https://github.com/fastlane/fastlane.git', branch: 'rogerluan-improve-precheck-failure-reason'

And run bundle install to apply the changes.

Here's a demo/sample:

image

Copy link
Member

@mollyIV mollyIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very welcome improvement 💯

Thank you!

@rogerluan rogerluan merged commit 24dc3b7 into master Oct 16, 2023
@rogerluan rogerluan deleted the rogerluan-improve-precheck-failure-reason branch October 16, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants