New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deliver] Add Watch Ultra screen size #21106
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I signed the CLA. |
3f4cf0d
to
8dba10e
Compare
3eba53d
to
0b02285
Compare
@joshdholtz This is the same changes as #19782. Please check again 馃檹 |
Could we get this merged, please? |
We have Deliver fails to upload Apple Watch Ultra screenshots. please check this 馃檹 |
Hello, is there any way to get this through? Many people including myself are now using Ultra as a default screenshot size for the watch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty obvious, I'd approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mollyIV Thank you so much! |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #21086
Uploading an Apple Watch Ultra screenshot fails with invalid size. The size is detailed in https://help.apple.com/app-store-connect/#/devd274dd925, however.
This is the same changes as #19782.