Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deliver] Add Watch Ultra screen size #21106

Merged
merged 1 commit into from Oct 17, 2023

Conversation

xiii111
Copy link
Contributor

@xiii111 xiii111 commented Mar 6, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Resolves #21086

Uploading an Apple Watch Ultra screenshot fails with invalid size. The size is detailed in https://help.apple.com/app-store-connect/#/devd274dd925, however.

馃毇 Error: ./fastlane/screenshots/ja/0_APP_WATCH_ULTRA_0.png - Invalid screen size (Actual size is 410x502. See the specifications to fix https://help.apple.com/app-store-connect/#/devd274dd925)

This is the same changes as #19782.

@google-cla
Copy link

google-cla bot commented Mar 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@xiii111
Copy link
Contributor Author

xiii111 commented Mar 6, 2023

I signed the CLA.

@xiii111 xiii111 marked this pull request as ready for review March 8, 2023 01:44
@xiii111
Copy link
Contributor Author

xiii111 commented Mar 9, 2023

@joshdholtz This is the same changes as #19782. Please check again 馃檹

@wrutkowski
Copy link

Could we get this merged, please?

@xiii111
Copy link
Contributor Author

xiii111 commented Sep 19, 2023

We have Deliver fails to upload Apple Watch Ultra screenshots. please check this 馃檹

@tkafka
Copy link

tkafka commented Sep 22, 2023

Hello, is there any way to get this through? Many people including myself are now using Ultra as a default screenshot size for the watch.

Copy link

@tkafka tkafka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty obvious, I'd approve

Copy link
Member

@mollyIV mollyIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xiii111 馃憢

Sorry for a late review. That looks good to me.

Thank you for the contribution 馃挴

@mollyIV mollyIV merged commit 35da455 into fastlane:master Oct 17, 2023
@xiii111
Copy link
Contributor Author

xiii111 commented Oct 18, 2023

@mollyIV Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Invalid screen size" error for Apple Watch Ultra
4 participants