Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a bit of the documentation of install_on_device.rb #21196

Merged
merged 1 commit into from Oct 17, 2023

Conversation

ls-1N
Copy link
Contributor

@ls-1N ls-1N commented Apr 14, 2023

It seems that the ios-deploy project's README.md suggests the use of brew over npm for installing their package since 2019. ios-control/ios-deploy@3714fc1

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.

Motivation and Context

Documentation includes outdated instructions

Description

Change the method of installation of the ios-deploy package suggested by fastlane documentation.

Testing Steps

It seems that the ios-deploy project's README.md suggests the use of `brew` over `npm` for installing their package since 2019. ios-control/ios-deploy@3714fc1
@google-cla
Copy link

google-cla bot commented Apr 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ls-1N ls-1N closed this Apr 14, 2023
@ls-1N ls-1N reopened this Apr 14, 2023
Copy link
Member

@mollyIV mollyIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 💯

Below you'll find a link to the mentioned pull request as a reference 😉

Remove node/npm from README installation steps (in favor of brew)

@mollyIV mollyIV merged commit e7e7aca into fastlane:master Oct 17, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants