Support Strict Concurrency for SnapshotHelper #21400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giginet
commented
Jul 16, 2023
| open class Snapshot: NSObject { | ||
| static var app: XCUIApplication? | ||
| static var waitForAnimations = true | ||
| static var cacheDirectory: URL? | ||
| static var screenshotsDirectory: URL? { | ||
| return cacheDirectory?.appendingPathComponent("screenshots", isDirectory: true) | ||
| } | ||
| static var deviceLanguage = "" | ||
| static var currentLocale = "" |
There was a problem hiding this comment.
It should be renamed to avoid conflicting setLocale implemented in this file between auto-generated by @objcMembers
|
@getaaron Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
When enabling
Strict ConcurrencytoComplete, SnapshotHelper raises some warnings.This PR makes to update
SnapshotHelperto suppress warnings.Description
All implementations of SnapshotHelper should be worked on
@MainActor.Testing Steps
bundle exec fastlane snapshot initStrict ConcurrencytoCompletebundle exec snapshot run