[match] remove redundant fetching of profile devices and certificates

[nekrich]

Checklist

• I've run bundle exec rspec from the root directory to see all new and existing tests pass
• I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
• I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
• I've read the Contribution Guidelines
• I've updated the documentation if necessary.

Motivation and Context

match is slow when running in edit mode. I found out that when the match checks device count and development certificates validity. match downloads a provisioning profile from the portal with devices and certificates payload and additionally sends two more requests to the portal to fetch devices and certificates once again. There is no need to fetch remote info twice.

Description

Changes allow match to use devices & certificates info from the first request from the received provisioning profile. As a result, the are 2x decrease in requests sent to App Store Connect API when checking if the provisioning profile must be updated.

Testing Steps

run match.

[nekrich]

@rogerluan , can you please look at this PR?

[rogerluan]

I also thought we had to fetch them again initially, but after reviewing the code better, this makes total sense to me!

However, since this is a critical part of match, I'll leave it for @joshdholtz to review it whenever he has some time, since he's the one who implemented this originally 🙇

[rogerluan]

Really nice catch btw @nekrich ! Thanks for this PR! 🙌

[nekrich]

Waited so long, and missed release. @joshdholtz , please review 🙏

[getaaron]

@nekrich @rogerluan one question before I merge, why does profile.rb have attr_accessor :certificates but not attr_accessor :devices? Should we add it for devices?

[rogerluan]

That's a really good question @getaaron 🤔 after analyzing the code it looks like it was just forgotten? Because it even has an entry in attr_mapping.

From code review alone it looks like this code would even crash due to lack of devices accessor, idk how this is actually working in real-life tests (in the unit test is understandable why it works, since we're mocking the accessor…).

Could you confirm whether that's the expected behavior or if there's an accessor missing, @nekrich ?

[nekrich]

@rogerluan Looks likes it's missing 🤔.

[nekrich]

Added the accessor, waiting for tests.

[nekrich]

Some tests failed, but I don't see any relationship with the changes I've made 🤔.

[rogerluan]

CI seems to have broke due to CircleCI's deprecation:

I'm taking a look at this now

[rogerluan]

Oh, this PR just needs rebasing from master @nekrich, would you do that for us? 🙏

[nekrich]

@rogerluan , @getaaron, sorry for the delay. I've just rebased my branch 🤞.

[rogerluan]

CI was failing, I just triggered it again to see if it was a flaky test.

[getaaron]

Tests look good. Thanks for the PR!