Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[snapshot] Add Missing Older iPhone & iPad models to Generated Snapshot Reports #21557

Merged
merged 5 commits into from Oct 7, 2023

Conversation

kylehowells
Copy link
Contributor

@kylehowells kylehowells commented Oct 6, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

I noticed running snapshot on some older iPhone and iPad models that they were missing. I worked out the list of supported devices for the report is hardcoded, so have updated the list of devices.

Description

Added missing older iPhone simulator names to the definitions used to output generated HTML files.

Also reordered the iPads and Apple Watches to that the all ascend from oldest to newest, in the same order as the iPhone models are listed.

@kylehowells
Copy link
Contributor Author

@getaaron New PR which adds back in the extra iPad and iPhone models from PR #21225 which weren't included in PR #21554

@kylehowells kylehowells changed the title Patch 3 [snapshot] Add missing newer iPhone & iPad models to Generated Snapshot Reports Oct 6, 2023
@kylehowells kylehowells changed the title [snapshot] Add missing newer iPhone & iPad models to Generated Snapshot Reports [snapshot] Add missing older iPhone & iPad models to Generated Snapshot Reports Oct 6, 2023
@kylehowells kylehowells changed the title [snapshot] Add missing older iPhone & iPad models to Generated Snapshot Reports [snapshot] Add Missing Older iPhone & iPad models to Generated Snapshot Reports Oct 6, 2023
@getaaron
Copy link
Collaborator

getaaron commented Oct 6, 2023

Thanks for the PR, @kylehowells! I don't think there will be any issues, but to be on the safe side can you login to CircleCI using GitHub OAuth so the tests run on your PR?

@getaaron getaaron merged commit 5cfa143 into fastlane:master Oct 7, 2023
3 checks passed
@getaaron
Copy link
Collaborator

getaaron commented Oct 7, 2023

Thanks again, @kylehowells!

If you're interested in a related issue I think nobody is working on #21558 yet

@kylehowells kylehowells deleted the patch-3 branch October 9, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants