Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Nexus password as a sensitive field #21564

Merged
merged 1 commit into from Oct 13, 2023

Conversation

liamjones
Copy link
Contributor

@liamjones liamjones commented Oct 9, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass - these were failing before I made my changes (may be my setup). bundle exec rspec ./fastlane/spec/actions_specs/nexus_upload_spec.rb worked
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary. - N/A
  • I've added or updated relevant unit tests. - N/A (I think)

Motivation and Context

When prompted for the Nexus password, nexus_upload was printing out what the user entered.

Description

Marked field as sensitive.

Testing Steps

Ran bundle exec fastlane run nexus_upload to confirm asterisks printed rather than the password after the change.
Existing tests for nexus_upload still pass, I can't see how I'd test the addition of the sensitive flag.

@google-cla
Copy link

google-cla bot commented Oct 9, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@getaaron
Copy link
Collaborator

Thanks!

@getaaron getaaron merged commit 2bef657 into fastlane:master Oct 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants