Mark Nexus password as a sensitive field #21564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests pass - these were failing before I made my changes (may be my setup).bundle exec rspec ./fastlane/spec/actions_specs/nexus_upload_spec.rb
workedbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
When prompted for the Nexus password,
nexus_upload
was printing out what the user entered.Description
Marked field as sensitive.
Testing Steps
Ran
bundle exec fastlane run nexus_upload
to confirm asterisks printed rather than the password after the change.Existing tests for nexus_upload still pass, I can't see how I'd test the addition of the sensitive flag.