Hide sensitive information in match output #21603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oct0f1sh
commented
Oct 28, 2023
| @@ -12,6 +12,7 @@ | |||
| 1257253924B7992C00E04FA3 /* main.swift in Sources */ = {isa = PBXBuildFile; fileRef = 1257253824B7992B00E04FA3 /* main.swift */; }; | |||
| 1267C3F42773A43E004DE48A /* Atomic.swift in Sources */ = {isa = PBXBuildFile; fileRef = 1267C3F32773A43E004DE48A /* Atomic.swift */; }; | |||
| 12D2EB8D2620D83C00844013 /* OptionalConfigValue.swift in Sources */ = {isa = PBXBuildFile; fileRef = 12D2EB8C2620D83B00844013 /* OptionalConfigValue.swift */; }; | |||
| 5F5D0ED98E02119343C05257 /* FastlaneRunner in FastlaneRunnerCopySigned */ = {isa = PBXBuildFile; fileRef = D556D6A91F6A08F5003108E3 /* FastlaneRunner */; settings = {ATTRIBUTES = (CodeSignOnCopy, ); }; }; | |||
There was a problem hiding this comment.
I think this file was changed when I ran unit tests. Should I revert the changes to this file?
There was a problem hiding this comment.
Removed in d995a7a
getaaron
reviewed
Oct 28, 2023
Just reverted the file in d995a7a, and hopefully my CircleCI link should be working 🤞 Thank you! 😁 |
getaaron
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
I've noticed that when running match, it tends to output the full WWDR certificate to the console. This has the potential to leak sensitive information, and I would prefer this not be directly viewable in CI logs. This was discussed in issues #21350 and #21351 (duplicate issues).
Description
As mentioned in a comment by user @AnubisFUp, you can silence this output by passing in
print: falseto the backticks action. I added their fix, along with updating tests to expect theprintparameter. I tested usingbundle exec rspecas well asbundle exec fastlane testTesting Steps
In a project that uses match for managing certificates, download your certificates as you usually would. Before this change, you would see your certificates being output to the console in bright purple text. Now, that output should be hidden.