Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notarization - Printing log on error #21609

Merged

Conversation

szigetics
Copy link
Contributor

@szigetics szigetics commented Nov 1, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

When the notarization is failing via altool there is no useful information printed.
Resolves #21608 and #20578 .

Description

Using xcrun altool log to request additional info about the error.

Testing Steps

@getaaron
Copy link
Collaborator

getaaron commented Nov 5, 2023

@szigetics thanks for the PR! the contribution looks good

Looks like you checked:

I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)

however I don't see the CircleCI builds — could you please doublecheck this?

@lacostej
Copy link
Collaborator

lacostej commented Nov 5, 2023

@szigetics thanks for the PR! the contribution looks good

Looks like you checked:

I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)

however I don't see the CircleCI builds — could you please doublecheck this?

Aren't they here?

@getaaron
Copy link
Collaborator

getaaron commented Nov 5, 2023

@szigetics thanks for the PR! the contribution looks good

Looks like you checked:

I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)

however I don't see the CircleCI builds — could you please doublecheck this?

Aren't they here?

Ah, looks like the tests did run but the information didn't propagate to the PR checks:

image

@szigetics
Copy link
Contributor Author

but the information didn't propagate to the PR checks

@getaaron : Do you know what could cause this? Should we just simply try to re-trigger the builds?
Other than this : does the PR look good? What do you think, when could this change be released? We would love to put our hands on a new version with this change... 🙂

@getaaron getaaron merged commit 5017060 into fastlane:master Nov 11, 2023
2 checks passed
@getaaron
Copy link
Collaborator

@szigetics thanks for the PR! The circleci doesn't show up on the PR unless the author has logged in to circleci with their GitHub account, I believe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notarize action - print_log parameter is not used for notarytool
3 participants