Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Add support for slather's new --ymlfile option #21613

Merged
merged 1 commit into from Nov 12, 2023
Merged

DRAFT: Add support for slather's new --ymlfile option #21613

merged 1 commit into from Nov 12, 2023

Conversation

jarrodlombardo-EventBase
Copy link
Contributor

@jarrodlombardo-EventBase jarrodlombardo-EventBase commented Nov 3, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

To be able to use slather from fastlane for a repo that has more than one .xcodeproj, slather needs to add support for custom ymlfiles. One that PR is released by Slather, this PR can be updated and merged to support that param from fastlane.

#21612

Description

  • Added ymlfile support to the Fastlane.swift slather function.
  • Added --ymlfile output to the slather action.
    • only allow ymlfile use for slather 2.8.0+ (This number will need to be changed if the slather release is a different version; latest is currently 2.7.5)
    • when checking for a config file, check the path of the ymlfile if provided and the regular .slather.yml if not.
  • added validate_params and ymlfile_available tests to the test spec.
  • Updated other tests to include the ymlfile param.

Testing Steps

bundle exec rspec and bundle exec rubocop -a are passing.
In the spec, the it "works with all parameters" test is generating the correct slather commandline with the new param.

Copy link
Collaborator

@getaaron getaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@getaaron getaaron merged commit cc19214 into fastlane:master Nov 12, 2023
2 checks passed
@jarrodlombardo-EventBase jarrodlombardo-EventBase deleted the jarrodlombardo/slather-ymlfile-support branch November 14, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants