Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect binding.irb in ensure_no_debug_code during build. #21635

Merged
merged 1 commit into from Dec 11, 2023

Conversation

mataku
Copy link
Contributor

@mataku mataku commented Nov 14, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Since binding.irb is a debugging tool available by default in Ruby supported by the current fastlane, we can use the REPL environment easily by writing binding.irb without the need for gem 'irb' etc.

Therefore, how about adding binding.irb as a target for debugging code checks if you want to ensure that no debugging codes?

Description

Add binding.irb by ensure_no_debug_code action

Testing Steps

bundle exec fastlane test

Copy link
Collaborator

@lacostej lacostej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me.

fastlane/Fastfile Outdated Show resolved Hide resolved
@lacostej lacostej changed the title Add binding.irb as a target for debugging code check detect binding.irb in ensure_no_debug_code during build. Dec 11, 2023
@lacostej lacostej merged commit 76862ca into fastlane:master Dec 11, 2023
2 checks passed
@lacostej
Copy link
Collaborator

Merged. Thanks!

@mataku mataku deleted the feature/check-irb branch December 20, 2023 03:29
SubhrajyotiSen pushed a commit to KeepTruckin/fastlane that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants