Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deliver] fix regression where changes made to the privacy URL fail to upload #21657

Merged
merged 3 commits into from Nov 22, 2023

Conversation

owjsub
Copy link
Contributor

@owjsub owjsub commented Nov 21, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Resolves #21654, fixing a regression introduced in #21472

Description

Previously, the localized key was not used when checking to see if the app info has changed during the deliver upload step, so it was always failing to upload changes to privacy urls. With this change, we now check the current value of the app info using the localized key so that it can compare the current and previous app info values as expected, allowing changes to the privacy url to upload as expected.

Testing Steps

  1. Change the privacy url in a project with fastlane/metadata/en-US/privacy_url.txt
  2. Use fastlane deliver to upload the change

@owjsub owjsub changed the title fix(deliver): fix issue where privacy url change fails to upload Fix issue where privacy url change fails to upload using deliver Nov 21, 2023
Copy link
Member

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing this issue, @owjsub ! 🙌

I checked and the test you added in fact doesn't work as of master, thanks for adding it 💯

This PR LGTM 💪

@rogerluan rogerluan changed the title Fix issue where privacy url change fails to upload using deliver [deliver] fix issue where privacy url change fails to upload Nov 22, 2023
@rogerluan rogerluan changed the title [deliver] fix issue where privacy url change fails to upload [deliver] fix regression where changes made to the privacy URL fail to upload Nov 22, 2023
@rogerluan rogerluan merged commit 003e3d9 into fastlane:master Nov 22, 2023
2 checks passed
@CraigSiemens
Copy link

CraigSiemens commented Dec 14, 2023

Thanks for fixing this. Any idea when there will be a new release with this fix? We're running into the same issue as well.

@rogerluan
Copy link
Member

We're working on a new release, just don't know when yet 😥 you can use master branch in your setup meanwhile, to not have to wait for the release 🙏

SubhrajyotiSen pushed a commit to KeepTruckin/fastlane that referenced this pull request Jan 17, 2024
…o upload (fastlane#21657)

* fix(deliver): fix issue where privacy url change fails to upload

* fix code style

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] Unable to edit privacy url using deliver on fastlane 2.217.0
3 participants