[action][spm] add parallel option
#21665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Support for ruby 3.2 was just added in CI. It should be resolved now. Thanks for the contribution! |
|
@lacostej Happy to contribute after using fastlane for a long time! Is there anything left for me to do to get this merged? |
|
@bramschulting one last idea: maybe we could add in the example section. |
lacostej
changed the title
parallel option
Good one, done! |
rogerluan
requested changes
Dec 13, 2023
rogerluan
approved these changes
Dec 13, 2023
|
Thanks @lacostej and @rogerluan! |
SubhrajyotiSen
pushed a commit
to KeepTruckin/fastlane
that referenced
this pull request
Jan 17, 2024
* Add parallel option to spm action * Add parallel test example * Change boolean option from optional to default false. --------- Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think something is wrong with my local setup, because if I runThis is resolved. I was using ruby 3.2.2 and with that the tests fail. But I noticed the CI uses 3.1 so I tried again locally with 3.1.2 and now they pass.bundle exec rspecon a clean clone of the fastlane repo on themasterbranch, I still get some failures:Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
swift testallows parallel testing by passing the--paralleloption. This reduces the time it takes to run the tests in a project. (In my case the time drops from 822 seconds to 133 seconds)Description
A
paralleloption has been added to theSpmActionaction. If this options is set totrueand thecommandis"test", the--parallelflag will be added to the command.This functionality has been tested by using my local fastlane setup in a real project.
There is one small issue: when the tests are run in parallel, there seems to be no output to fastlane while the tests are running. When the tests complete (either successfully or as a failure), the output is shown. I don't know how to resolve this, so if anyone has an idea, feel free to let me know! But otherwise I think it's a tradeoff users of the
parallelflag can make. I suspect the issue is that when running the tests with the--paralleloption, output is not 'appended', but there's only one line that's constantly being removed and rewritten. You can see this happening when runningswift test --paralleldirectly.Testing Steps
Create a lane that uses the
spm(command: 'test', parallel: true)action.