Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide xcodebuild stderr to solve #21672 #21673

Merged
merged 1 commit into from Nov 29, 2023

Conversation

lacostej
Copy link
Collaborator

See #21672

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

Description

I haven't found a way to get rid of those issues, so hiding them by merging them with stdout. It doesn't affect the parsing of the settings as no stderr line contains a =.

Testing Steps

Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hides all of stderr logs though, without an option to see them. And iinm, while we tee the stdout to a file especially to allow people to still browse the full log even when they pipe thru xcpretty / xcbeautify, we don't have an equivalent for being able to browse stderr messages optionally if they're masked in the streamed output.


[EDIT] I just realized that that patch is only applied to the command that generates -showBuildSettings, so I think that's ok; as I don't expect much valuable info from stderr on that specific command. Just wanted to make sure we don't swallow stderr on the regular xcodebuild build commands like we'd do for showBuildSettings, but that seems to be good here 👍

@lacostej lacostej merged commit 142cfba into fastlane:master Nov 29, 2023
2 checks passed
@lacostej lacostej deleted the fix/hide_xcodebuild_stderr branch November 29, 2023 11:27
SubhrajyotiSen pushed a commit to KeepTruckin/fastlane that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants