[fastlane_core] add support to Ruby 3.3 #21683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacostej
force-pushed
the
fix/ruby_3_3_compatibility
branch
from
b74dc53
to
49e0d4a
Compare
…ible with ruby 3.3
…ible with ruby 3.3
…te for internal changes in ruby 3.3 evaluation of __FILE__ within the eval() call
lacostej
force-pushed
the
fix/ruby_3_3_compatibility
branch
from
49e0d4a
to
e20f960
Compare
rogerluan
requested changes
Dec 13, 2023
Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
I would. Then we are ready to add ruby 3.3 as soon as it is available on circle. |
rogerluan
approved these changes
Dec 14, 2023
SubhrajyotiSen
pushed a commit
to KeepTruckin/fastlane
that referenced
this pull request
Jan 17, 2024
* Relax regular expression that captures compilation error to be compatible with ruby 3.3 * Relax regular expression that captures compilation error to be compatible with ruby 3.3 * Change the way we build the test and its expected results to accomodate for internal changes in ruby 3.3 evaluation of __FILE__ within the eval() call * Update fastlane/spec/plugins_specs/plugin_generator_spec.rb Co-authored-by: Roger Oba <rogerluan.oba@gmail.com> --------- Co-authored-by: Roger Oba <rogerluan.oba@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 tests are failing in ruby 3.3.0-preview3
ruby 3.3. isn't yet available on circleci though.
Checklist
bundle exec rspecfrom the root directory to see all new and existing tests passbundle exec rubocop -ato ensure the code style is validci/circlecibuilds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Description
Testing Steps
rspec