Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spaceship] add Spaceship::ConnectAPI::AppPreviewSet::PreviewType::IPHONE_67 #21710

Merged
merged 1 commit into from Dec 12, 2023

Conversation

drcreazy
Copy link
Contributor

@drcreazy drcreazy commented Dec 11, 2023

Checklist

  • I've run bundle exec rspec from the root directory to see all new and existing tests pass
  • I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
  • I see several green ci/circleci builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary.
  • I've added or updated relevant unit tests.

Motivation and Context

During the integration I found there is no IPHONE_67 constant in this class so impossible to use constant

Description

Added IPHONE_67 support to app_preview_set model

@drcreazy drcreazy changed the title Spaceship: IPHONE_67 constant added to app_preview_set ConnectApi: IPHONE_67 constant added to app_preview_set Dec 11, 2023
@lacostej lacostej changed the title ConnectApi: IPHONE_67 constant added to app_preview_set [spaceship] add Spaceship::ConnectAPI::AppPreviewSet::PreviewType::IPHONE_67 Dec 11, 2023
@lacostej lacostej changed the title [spaceship] add Spaceship::ConnectAPI::AppPreviewSet::PreviewType::IPHONE_67 [spaceship] add Spaceship::ConnectAPI::AppPreviewSet::PreviewType::IPHONE_67 Dec 11, 2023
@lacostej lacostej merged commit f648513 into fastlane:master Dec 12, 2023
2 checks passed
SubhrajyotiSen pushed a commit to KeepTruckin/fastlane that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants