[plugin_generator] move development dependencies from *.gemspec.erb
to Gemfile.erb
#21726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
This is a follow up PR similar to #21725
This is the recommended best practice as per RuboCop https://docs.rubocop.org/rubocop/cops_gemspec.html and there was an exception disabling this rule previously.
Description
The only thing I couldn't enable was ensuring that the
Gemfile.erb
gems are sorted alphabetically, because apparently even if I add- Include
statement forGemfile.erb
in the rubocop config file, it will ignore it and will only look forGemfile
,.gemspec
and.gems
files in custom directories 😞 The gems are already sorted alphabetically, though, and since this file pretty much never receives updates, this is good enough.I also added a brief comment about what each dependency does. I think this is great for newcomers and helps lower the contribution barrier 😊 which is especially helpful when users are developing new plugins.
Testing Steps
To test this branch, modify your Gemfile as:
And run
bundle install
to apply the changes.Then run:
bundle exec fastlane new_plugin this-is-my-test
Screenshot demo'ing this working (notice the Gemfile was generated correctly, including the version placeholders):