Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Datacenter.Coordinates - Longtitude #274

Open
briemarie opened this issue May 11, 2021 · 2 comments
Open

Typo in Datacenter.Coordinates - Longtitude #274

briemarie opened this issue May 11, 2021 · 2 comments

Comments

@briemarie
Copy link

briemarie commented May 11, 2021

I'm happy to contribute to fixing this, but wanted to raise an issue to get a consensus on how trivial it actually is.

Would getting the typo fixed in the name cause the need for a major revision change? At least the mapstructure tag is spelled correctly, so its not a big deal, found it when I spelled it correctly and got an error though.

https://github.com/fastly/go-fastly/blob/main/fastly/datacenters.go#L6

Screen Shot 2021-05-10 at 5 54 04 PM

@Integralist
Copy link
Collaborator

Hi @briemarie I personally would consider this a breaking change because Coordinates is a publicly exported type and so there may well be users of go-fastly that have code written using the misspelling of Longtitude.

@dgryski
Copy link
Member

dgryski commented Aug 16, 2022

This is fairly straight-forward to add a semgrep or ruleguard rule to make upgrading automatic.

OTOH, https://en.wikipedia.org/wiki/HTTP_referer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants