Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Exit status is not 0 when the skunk score improved #104

Open
arielj opened this issue Oct 26, 2023 · 0 comments
Open

[BUG] Exit status is not 0 when the skunk score improved #104

arielj opened this issue Oct 26, 2023 · 0 comments

Comments

@arielj
Copy link
Contributor

arielj commented Oct 26, 2023

Branch/Commit:

Version 0.5.2.

Expected behavior:

When comparing 2 branches, if the new branch has a better skunk score above the threshold, the exit status of the command should be 0 so it's not considered a failure.

Actual behavior:

When the score improves above the threshold, the exit status is non-zero so it's considered a failure in CI.

From this PR https://github.com/fastruby/skunk.fyi/actions/runs/6655872886/job/18087134376?pr=103

image

Steps to reproduce:

Run the compare command for a new PR improving the skunk score average by more than the threshold.

I will abide by the code of conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant