Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for projects #63

Merged
merged 9 commits into from
Nov 9, 2021
Merged

Add support for projects #63

merged 9 commits into from
Nov 9, 2021

Conversation

etagwerker
Copy link
Member

Hey,

This PR adds support for the idea of projects. It doesn't entirely fix #31 but it is a necessary step in that direction.

Known Issues

  • This code is not secure. Anyone could just specify a project id/permalink and attach a report to that project.
  • For this app to support access verification, we will need to introduce some form of API key to validate that the person submitting the report can attach a report to the specified project
  • Skunk does not currently support the idea of projects. This PR provides a pathway for skunk to know what it needs to send when sharing a report for a project
  • It would be cool to do something like accepting a GitHub url to create a new project in the site (like RubyDoc.info does)

Screen Shot 2021-11-06 at 9 48 06 PM

I will abide by the code of conduct.

@etagwerker etagwerker requested review from a team, lubc and kindoflew and removed request for a team November 7, 2021 01:49
@lubc lubc temporarily deployed to skunk-staging November 7, 2021 18:12 Inactive
Copy link
Contributor

@lubc lubc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etagwerker Looks good 👍 I just added some small comments/questions

test/controllers/reports_controller_test.rb Outdated Show resolved Hide resolved
test/controllers/reports_controller_test.rb Show resolved Hide resolved
app/controllers/reports_controller.rb Show resolved Hide resolved
@etagwerker etagwerker requested a review from a team as a code owner November 9, 2021 03:56
@lubc
Copy link
Contributor

lubc commented Nov 9, 2021

Just did a smoke test on staging to make sure nothing is breaking. It's all good 👍

@lubc lubc merged commit de4b661 into main Nov 9, 2021
@lubc lubc deleted the feature/add-projects-support branch November 9, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] I want to see my skunk score average over time (for a particular project)
2 participants