From 54f67c1d1d4ec9607d8719dc3f18c3503abadf4e Mon Sep 17 00:00:00 2001 From: Carl-Erik Kopseng Date: Tue, 4 Jul 2017 15:56:39 +0200 Subject: [PATCH] Avoid running test for #1456 on Safari --- test/issues/issues-test.js | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/test/issues/issues-test.js b/test/issues/issues-test.js index 99461e547..9280f08e1 100644 --- a/test/issues/issues-test.js +++ b/test/issues/issues-test.js @@ -7,7 +7,6 @@ var configureLogError = require("../../lib/sinon/util/core/log_error.js"); var assert = referee.assert; var refute = referee.refute; - describe("issues", function () { beforeEach(function () { this.sandbox = sinon.sandbox.create(); @@ -252,7 +251,20 @@ describe("issues", function () { }); if (typeof window !== "undefined") { + + var throwsOnUnconfigurableProperty = false; + var preDescriptor = Object.getOwnPropertyDescriptor(window, "innerHeight"); + /* eslint-disable no-restricted-syntax */ + try { + Object.defineProperty(window, "innerHeight", { value: 10, configureable: true, writeable: true }); + Object.defineProperty(window, "innerHeight", preDescriptor); + } catch (err) { + throwsOnUnconfigurableProperty = true; + } + /* eslint-enable no-restricted-syntax */ + describe("#1456", function () { + if (throwsOnUnconfigurableProperty) { return; } var sandbox; beforeEach(function () {