Add isEmpty utility method #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb55
reviewed
Jan 4, 2024
src/index.ts
Outdated
Comment on lines
39
to
44
| /** Variable to store the count of bits set to 1 */ | ||
| private setBitCount: number = 0; | ||
|
|
||
| /** Set to keep track of indices of set bits */ | ||
| private readonly setBits: Set<number> = new Set(); | ||
|
|
There was a problem hiding this comment.
I would like to keep the memory usage of bitfield the same as it is, and especially the set will require quite a bit more memory. They are also not needed for isEmpty. Let's remove them?
package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "bitfield", | |||
| "description": "a simple bitfield, compliant with the BitTorrent spec", | |||
| "version": "4.1.0", | |||
| "version": "4.2.0", | |||
There was a problem hiding this comment.
npm version bumps this, please don't change it manually.
|
I went ahead and addressed my review comments. Thanks @TJKoury! |
|
Awesome! Thanks for accepting; those other methods help with time complexity but at the cost of memory (as always is the trade-off). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added isEmpty utility method. Needed a more efficient way to check if a BitField instance has no set bits, using early return for positives.