Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreventChanges opposite #503

Closed
issy123 opened this issue Jan 19, 2019 · 1 comment
Closed

PreventChanges opposite #503

issy123 opened this issue Jan 19, 2019 · 1 comment

Comments

@issy123
Copy link

issy123 commented Jan 19, 2019

info

https://feathers-plus.github.io/v1/feathers-hooks-common/#preventchanges

PreventChanges hook tells us in the detail section to use validateSchema if you would rather specify which fields are allowed to change. ValidateSchema seems a bit too complex for a simple problem to only keep 1 or 2 fields.

So why not suggest keep instead of validateSchema?

Expected behavior

  • Details

Consider using keep in the before hook if you would rather specify which fields are allowed to change.

Actual behavior

  • Details

Consider using validateSchema if you would rather specify which fields are allowed to change.

@fratzinger
Copy link
Collaborator

Closing this because there's no recent activity. If this still bugs you, please feel free to answer or please open a PR. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants