Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepQuery does not keep '$' query fields #611

Open
stellarhoof opened this issue Nov 4, 2020 · 1 comment
Open

keepQuery does not keep '$' query fields #611

stellarhoof opened this issue Nov 4, 2020 · 1 comment
Labels
awaiting response

Comments

@stellarhoof
Copy link

stellarhoof commented Nov 4, 2020 •
edited

Steps to reproduce

[keepQuery('field'), disablePagination()] does not work since keepQuery removes $limit

Expected behavior

keepQuery should either keep dollar query fields or a new hook should be provided.
@fratzinger
Copy link
Collaborator

Why don't you use this: [keepQuery('field', '$limit'), disablePagination()] ?

I think a callback would be useful. Something like: [keepQuery((key) => key.startsWith('$'), 'field'), disablePagination()]. Are you up to add this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting response
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stellarhoof @fratzinger