Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider deprecation of disable-multi-item-change #651

Open
1valdis opened this issue Jan 28, 2022 · 0 comments
Open

Reconsider deprecation of disable-multi-item-change #651

1valdis opened this issue Jan 28, 2022 · 0 comments

Comments

@1valdis
Copy link

1valdis commented Jan 28, 2022

The deprecation notice suggests usage of multi: true option, but the problem is multi: true has no flexibility at all and sets the behavior for both internal and external calls (see feathersjs/feathers#2546), while the disableMultiItemChange hook be used conditionally, for example iff(isProvider('external'), disableMultiItemChange()). Due to its flexibility, I think its deprecation should be reconsidered and it could be included back to feathers-hooks-common.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant