Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong lodash imports #674

Closed
geoynomous opened this issue Jun 6, 2022 · 3 comments · Fixed by #684
Closed

Wrong lodash imports #674

geoynomous opened this issue Jun 6, 2022 · 3 comments · Fixed by #684

Comments

@geoynomous
Copy link

Steps to reproduce

Upon import seeing this

Cannot find module '/appserver/node_modules/.pnpm/feathers-hooks-common@6.1.0/node_modules/lodash/pick' imported from /appserver/node_modules/.pnpm/feathers-hooks-common@6.1.0/node_modules/feathers-hooks-common/dist/index.mjs
Did you mean to import lodash@4.17.21/node_modules/lodash/pick.js?

There is douzens of such problems with lodash

Expected behavior

a '.js' seems to be missing

Actual behavior

An error shows up

System configuration

Module versions (especially the part that's not working):

6.1.1

NodeJS version:

16.15.0

Operating System:

macOS

@OADesigns
Copy link

getting same issue on Ubuntu node 16.13.1. Only when using import, works fine with require.
Manually changing all the lodash imports in index.mjs and adding .js to end of paths also removes error.

@JoseCadenas
Copy link

I am experiencing this issue on all version 6+ updates. I am staying on 5.0.6 until a patch is found.

@fratzinger
Copy link
Collaborator

released as feathers-hooks-common@6.1.5. Please check. A confirmation that it's working would be highly appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants