Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error check when missing entity #123

Open
ericuldall opened this issue Feb 8, 2022 · 2 comments
Open

No error check when missing entity #123

ericuldall opened this issue Feb 8, 2022 · 2 comments

Comments

@ericuldall
Copy link

If doing a permissions check on a route that may be accessed by a logged out user there is no check for the error flag.
https://github.com/feathersjs-ecosystem/feathers-permissions/blob/release/lib/index.js#L33

This causes an issue because currently I'm using permissions check in users before hooks with error false. This makes it easier than implementing it on every method except POST (which you would obviously be logged out for in the event of a new registration).

Is there some reason the error check is not implemented there?

@ericuldall
Copy link
Author

Sent a PR if there's no objection to it.

@ericuldall
Copy link
Author

Just realized this issue was closed as stale before but I think the OP had a valid point and happy to further the discussion.
#71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant