Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please put potential build issues here #304

Closed
marshallswain opened this issue Oct 21, 2019 · 5 comments
Closed

Please put potential build issues here #304

marshallswain opened this issue Oct 21, 2019 · 5 comments

Comments

@marshallswain
Copy link
Member

marshallswain commented Oct 21, 2019

If you run into issues with the build for feathers-vuex@2.x, please comment in this issue. So far, I've been able to work around issues by copying feathers-vuex into the src folder of my Vue projects. If you find an issue you can't seem to resolve, this is the recommended solution until we've documented the possible options.

You can look at previous conversation about the topic on the PR: #216

@corepay
Copy link

corepay commented Oct 21, 2019

:) nice surprise to open the docs and see the updates this morning!

Documentation issue or bug:

Not sure which but following along upgrading pre22 -> looks like you added feathers-hooks-common and imported iff but I think you also need to import discard - I ma getting linter error, comment out then build to blank page. Adding discard to the import everything seems to be good again but I dont know up from down re: feathers-hooks-common

image

@marshallswain
Copy link
Member Author

@corepay thanks! fixed

@ivankostic85
Copy link
Contributor

Hi, @marshallswain nice work.

I have upgraded my app to the latest feathers vuex but current getter is missing? If this getter is removed, docs need to be fixed.

@marshallswain
Copy link
Member Author

@ikakosta thanks for bringing this to my attention. I will update the docs.

https://feathers-vuex.feathers-plus.com/2.0-major-release.html#the-currentitem-workflow-is-no-longer-supported

@marshallswain
Copy link
Member Author

@ikakosta docs are updated. Please have a look in about 5 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants