Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After update to 3.9.0 I get error "export is not defined" #450

Closed
anli-xsigns opened this issue Mar 19, 2020 · 3 comments
Closed

After update to 3.9.0 I get error "export is not defined" #450

anli-xsigns opened this issue Mar 19, 2020 · 3 comments

Comments

@anli-xsigns
Copy link
Contributor

anli-xsigns commented Mar 19, 2020

Hi Marshal,
thanks a lot for your great work last weekend! I just wanted to check your updates out but after updating to the last version (3.9.0) with feathersjs 4.5.2 I get the following error:

Uncaught ReferenceError: exports is not defined
    at eval (webpack-internal:///./node_modules/feathers-vuex/node_modules/@feathersjs/commons/lib/hooks.js:28)
    at Module../node_modules/feathers-vuex/node_modules/@feathersjs/commons/lib/hooks.js (vendor.js:5403)
    at __webpack_require__ (app.js:790)
    at fn (app.js:151)
    at eval (webpack-internal:///./node_modules/feathers-vuex/node_modules/@feathersjs/commons/lib/index.js:23)
    at Object../node_modules/feathers-vuex/node_modules/@feathersjs/commons/lib/index.js (vendor.js:5415)
    at __webpack_require__ (app.js:790)
    at fn (app.js:151)
    at eval (webpack-internal:///./node_modules/feathers-vuex/dist/service-module/service-module.getters.js:21)
    at Module../node_modules/feathers-vuex/dist/service-module/service-module.getters.js (vendor.js:5319)

I don't have an idea where to search...

I use quasar 1.9.10 and have defined

build: {
  transpileDependencies: ['feathers-vuex']
},

in quasar.conf (worked well before)

@anli-xsigns
Copy link
Contributor Author

anli-xsigns commented Mar 19, 2020

OK, I had to remove the transpiledDependencies:

build: {
  transpileDependencies: []
},

Than it works again. Maybe we should update documentation (https://github.com/feathersjs-ecosystem/feathers-vuex/blob/master/docs/getting-started.md)?

@marshallswain
Copy link
Member

marshallswain commented Mar 19, 2020

That's really weird. I didn't have to change anything. (My apps all use Vue CLI and Gridsome.) And none of the dependencies change in the release. To my comprehension, you should still be required to have transpileDependencies. Maybe something changed in Quasar's build system?

@anli-xsigns
Copy link
Contributor Author

This solved it: #216 (comment). Maybe we should add to documentation at https://github.com/feathersjs-ecosystem/feathers-vuex/blob/master/docs/getting-started.md#quasar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants