Knex adapter create performance when multi

[howlettt]

When multiple rows are being inserted using the Knex adapter, they're all being inserted & then selected in separate database calls. Is there a reason the rows aren't being passed in as a list to Knex so they can all be inserted in one database call?

feathers/packages/knex/src/adapter.ts

Lines 238 to 240 in 82d30fd

	if (Array.isArray(data)) {
	return Promise.all(data.map((current) => this._create(current, params)))
	}

According to the Knex documentation inserting a array of rows is supported
https://knexjs.org/guide/query-builder.html#insert

Creates an insert query, taking either a hash of properties to be inserted into the row, or an array of inserts, to be executed as a single insert command

[howlettt]

Looks like not all databases support returning the ids for all the inserted rows when inserting multiple at once

https://knexjs.org/guide/query-builder.html#insert

// Returns [2] in "mysql", "sqlite"; [2, 3] in "postgresql"

knex/knex#1828

[howlettt]

Related: #2945