fix: EquatableMixin == to use Object instead of Object?

[felangel]

Status

READY

Breaking Changes

YES (but it is considered a bug fix)

Description

Overriding == should use Object instead of Object? (revert #108) closes #115

@override
bool operator ==(Object other) {...}

[jeroen-meijer]

Not a maintainer but, LGTM!

[whitemagehealing]

Does this mean that Equatable currently cannot compare an object composed of mixed types (nullable and non-nullable)?

[felangel]

Does this mean that Equatable currently cannot compare an object composed of mixed types (nullable and non-nullable)?

That should still work:

import 'package:equatable/equatable.dart';

class CustomEquatable extends Equatable {
  const CustomEquatable(this.value);

  final String value;

  @override
  List<Object> get props => [value];
}

void main() {
  final CustomEquatable instanceA = CustomEquatable('A');
  final CustomEquatable? instanceB = CustomEquatable('A');

  print(instanceA == instanceB); // true
}

[whitemagehealing]

Thank you for the example! I managed to edit it to match my silly question and test it. :)

import 'package:equatable/equatable.dart';

class CustomEquatable extends Equatable {
  const CustomEquatable({required this.value, this.nullVal});

  final String value;
  final String? nullVal;

  @override
  List<Object?> get props => [value, nullVal];
}

void main() {
  final CustomEquatable instanceA = CustomEquatable(value: 'A');
  final CustomEquatable? instanceB = CustomEquatable(value: 'A');

  print(instanceA == instanceB); // true
}