Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for publishing platform-specific .vsix #280

Merged
merged 7 commits into from
Nov 15, 2022

Conversation

felipecrs
Copy link
Owner

@felipecrs felipecrs commented May 14, 2022

New features

  • The existing packageVsix option can now be explicitly disabled with false
  • A new publishPackagePath option was added, which allows the use of globs like *.vsix
  • A new environment variable is supported: VSCE_TARGET

Check the documentation for an example on how these new features can be combined to achieve platform-specific extensions publishing.

@felipecrs
Copy link
Owner Author

felipecrs commented May 14, 2022

@GitMensch and @mbehr1, I haven't started coding the feature yet, but I updated the documentation with what I have in mind.

Would you mind taking a look at it, to see if the approach is acceptable?

Any feedback is welcome.

@felipecrs felipecrs force-pushed the multi-arch branch 4 times, most recently from 94e87d8 to 15d9f18 Compare September 6, 2022 14:59
@mbehr1
Copy link

mbehr1 commented Sep 7, 2022

@felipecrs yep, useful! I'll try to migrate my workflows to that approach.

@felipecrs
Copy link
Owner Author

I'll try to merge the PR in the coming days so. :)

@felipecrs felipecrs force-pushed the multi-arch branch 3 times, most recently from e0a78d7 to f18b67c Compare October 31, 2022 18:14
@felipecrs
Copy link
Owner Author

Oh wow, this got so complicated. But it's finally coming to an end.

@felipecrs felipecrs changed the title feat: add support for platform-specific feat: add support for publishing platform-specific .vsix Nov 15, 2022
@felipecrs felipecrs marked this pull request as ready for review November 15, 2022 19:12
@felipecrs felipecrs merged commit 59eeb34 into master Nov 15, 2022
@felipecrs felipecrs deleted the multi-arch branch November 15, 2022 19:15
@github-actions
Copy link

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants