Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M-; doesn't move to the end of the line when using it with no region #84

Open
UwUnyaa opened this issue Sep 21, 2018 · 2 comments
Open
Labels

Comments

@UwUnyaa
Copy link

UwUnyaa commented Sep 21, 2018

Using M-; with no region (on an empty line or one with some code) doesn't cause the point to jump to the end of it so I can start typing a comment right away, which is how comment-dwim normally behaves.

Here's a recording of the problem, along with the same test performed in js2-jsx-mode, which doesn't have this problem:
https://asciinema.org/a/202462

@felipeochoa
Copy link
Owner

Have you looked at #83? Is this independent of that?

@UwUnyaa
Copy link
Author

UwUnyaa commented Sep 23, 2018

It doesn't seem to be related to that issue and it seems to be 100% consistent. It's not related to executing commands before a reparse is complete, in both scenarios I've shown the entire buffer gets reparsed before I type M-;. After updating rjsx-mode to a version which fixes rjsx indentation and ads support for proper JSX comments (which don't seem to work with empty region at all) I've been facing this issue every time I wanted to make a comment in my code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants