You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From #131. We can't refactor the sender module yet, but I have an idea for an improvement. It would break setting defaults though. We could divide the module into submodules like this:
sender.base: Sender, Async/Sync Sender
sender.concrete: Transient, Persistent and Singleton sync/async senders
sender.extend: Retrying / other extensions that we come up with
sender.default: kwargs / sender instance / sender type
This would actually improve setting defaults. Instead of two imports, we could do one:
I realise the old example could be done with one import, but it would lead to longer names. And now there is no problem importing defaults in other sender submodules. The client base class could also be in e.g. sender.client or base.
The text was updated successfully, but these errors were encountered:
From #131. We can't refactor the sender module yet, but I have an idea for an improvement. It would break setting defaults though. We could divide the module into submodules like this:
This would actually improve setting defaults. Instead of two imports, we could do one:
I realise the old example could be done with one import, but it would lead to longer names. And now there is no problem importing defaults in other sender submodules. The client base class could also be in e.g. sender.client or base.
The text was updated successfully, but these errors were encountered: