Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Hishel or another solution for http caching #298

Open
felix-hilden opened this issue Sep 28, 2023 · 3 comments
Open

Consider using Hishel or another solution for http caching #298

felix-hilden opened this issue Sep 28, 2023 · 3 comments
Labels
enhancement New feature or improvement

Comments

@felix-hilden
Copy link
Owner

Hishel provides HTTP caching for HTTPX. We could use that and delete our custom caching logic (which is likely poorly implemented and won't be up to date)

@felix-hilden felix-hilden added the enhancement New feature or improvement label Sep 28, 2023
@felix-hilden
Copy link
Owner Author

And rather than use that and introduce a dependency, we could just document the existence of these automatic caches for HTTPX and Requests, and remove the functionality altogether.

@karpetrosyan
Copy link

If you decide to use Hishel, I can issue a PR that adds Hishel.

@felix-hilden
Copy link
Owner Author

Thank you! I think I'll let it sit for a while, particularly because Hishel is still in early development. But when we do this, I think it'll be just documenting this and removing all the custom functionality rather than using Hishel internally - as I laid out above 👍 Come that time though, I'd be happy to accept a contribution if you're still around. I can ping you if you'd like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants