Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worktree.Status with diff #34

Open
ghost opened this issue Mar 8, 2023 · 1 comment
Open

Worktree.Status with diff #34

ghost opened this issue Mar 8, 2023 · 1 comment

Comments

@ghost
Copy link

ghost commented Mar 8, 2023

I see you used Worktree.Status with git commit:

status, err := w.Status()

and with git status:

status, err := w.Status()

but with git diff you are manually checking the content difference:

gig/cli/diff.go

Line 129 in dd59dc9

if fromContent != toContent {

when I think Worktree.Status could do that for you. Is this an oversight, or is Worktree.Status a bad option for some reason?

@fhs
Copy link
Owner

fhs commented Mar 8, 2023

I don't remember very well. It was probably an oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant