Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: files and directories are created with the correct permissions #2966

Merged
merged 6 commits into from
Jan 30, 2024

Conversation

Nerahikada
Copy link
Contributor

@Nerahikada Nerahikada commented Jan 26, 2024

Description

The magic number for permissions is removed and files and directories are now created with consistent permissions.
Related issue: #2535

馃毃 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • DO make sure that related issues are opened in other repositories. I.e., the frontend, caddy plugins or the web page need to be updated accordingly.
  • AVOID breaking the continuous integration build.

Further comments

@Nerahikada Nerahikada changed the title fix: files are created with the correct permissions fix: files and directories are created with the correct permissions Jan 26, 2024
@o1egl o1egl merged commit 5c5ab6b into filebrowser:master Jan 30, 2024
7 of 8 checks passed
@Nerahikada Nerahikada deleted the fix/less-file-perm branch January 30, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants